@geomydas
Posted
Hi @drxdesign, your code and solution looks good but it has some few minor issues. Don't worry! Most of these issues are really easy to fix and are often done at this level. I used to do the same mistakes aswell in the past.
My Tips and Suggestions
- Use TailwindCSS via their NPM package. Using their CDN lacks their other features such as their arbitrary values. Therefore, you can remove the
x </button>. For sighted people, it works fine. For unsighted people, they don't understand the meaning of x. - Replace the first div with a main tag. Tag is self explanatory. Main content. A site should have atleast 1 main tag
- Consider self-hosting your fonts instead of using Google Fonts. Using Google Fonts is slower and also violates GDPR which is bad for privacy. You shouldn't really worry about this for now but in larger enterprise websites, you could get sued for that.
That is all. Don't feel demotivated by this as it is part of our learning. You can treat this as a checkbox and do them one by one. Have a nice day and have fun coding!
Marked as helpful
@drxdesign
Posted
Thank you for the feedback. I really appreciate it and when it comes to what you said. I'll try to do it next I did this because I'm trying to learn as much as I can in a short time So when it comes to using cdns and stuff like that, it's just to make things more quicker for myself But you are right overall. And I'll try to fix this later. So thank you again @geomydas
