Design comparison
Solution retrospective
Another simple Mentor challenge complete! Although this was a simple challenge i have managed to still learn from it. Working out how to get the shadow effect was tricky enough. but thankfully after watching a few youtube videos It seems it was easier than i thought! and i learned a little about absolute and relative positioning along the way. I also figured out to to stop the button/anchor tag from taking up the full width of the flexed section by using w-fit. who knew it was so simple eh?
As always please don't hesitate to give me some constructive criticism as for me its the best way to learn. Thanks in advance
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @JohnPugh688!
Your solution looks excelent!
I have just one suggestion:
š In order to make your HTML code more semantic, use
<h1>
for the main title instead of<h2>
.Unlike what most people think, it's not just about the size and weight of the text.
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
defines the most important heading.<h6>
defines the least important heading.- Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.
All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0@JohnPugh688Posted 9 months ago@danielmrz-dev Every day's a school day š Thanks again for your advice.
0 - The
- @Alokray007Posted 9 months ago
Hello there š
Good job on completing the challenge !
Your project looks really good!
I have a suggestion about your code that might interest you.
There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.
š Tags like <div> and <span> are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page. This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope this suggestion is useful for future projects.
Other than that, great job!
Happy coding.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord