Design comparison
Solution retrospective
Hi Frontend Community 👋
Here is my solution for this challenge .If u have any suggestion or feedback regarrding this solution, feel free to mention it
Ty ✌
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @KruzadeR-VictoR!
Your solution looks great!
I have a couple of suggestions for improvement:
- In order to make your HTML code more semantic, and since that is the main title of the screen, replace the
<h2>
with<h1>
. Unlike what most people think, it's not just about the size and weight of the text.
The
<h1>
to<h6>
tags are used to define HTML headings.<h1>
defines the most important heading.<h6>
defines the least important heading. Only use one<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on.- Also, still about semantic HTML, instead of using
div#root
andmain.css-82c5pm"
as containers, you can just use onlymain
tag.
All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
1 - In order to make your HTML code more semantic, and since that is the main title of the screen, replace the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord