Design comparison
Solution retrospective
Looks good to me, maybe the title is a little bigger than in the design.
Community feedback
- @ZukizukPosted 9 months ago
Hello there, Congratulations on completing this project
Your solution looks nice
I have few suggestions that I think might be of interest to you.
According to the HTML specification, a page should only have one <main> element. The <main> element represents the main content of the document, and it's intended to contain the primary content that is directly related to or expands upon the central topic of the document. You have two main tags in your html code so please consider fixing that. Also you page didn't have a h1 tag and every page need an h1 tag as the main subject or main heading. You can read more about them here heading element.
I hope this feedback is helpful
Other than that great job
Marked as helpful0 - @danielmrz-devPosted 9 months ago
Hello @deedeedev!
Your solution looks excelent!
I have just one suggestion:
📌 In order to make your HTML code more semantic, use
<h1>
for the main title instead of<a>
. Or at least wrap the text with<h1>
inside the tag<a>
. This text is not just a link, it's also the main title of the screen.Unlike what most people think, it's not just about the size and weight of the text.
-
The
<h1>
to<h6>
tags are used to define HTML headings. -
<h1>
defines the most important heading. -
<h6>
defines the least important heading. -
Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.
All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
0 -
- @RPRd001Posted 10 months ago
It looks very nice congratulations, I think that it is just a matter of adjusting the padding for the component container.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord