Design comparison
Solution retrospective
I got the design pretty close and the hover and focus states seem to work
What challenges did you encounter, and how did you overcome them?Mostly just trying to get the design as close as possible on desktop and mobile. I used a media query to tweak the mobile version just a little bit to match the image.
What specific areas of your project would you like help with?Ensuring that I got the accessibility portion correct this time, as I did not do that on the first project. I think the code is sound though.
Community feedback
- @Alex-Archer-IPosted 5 months ago
Hi!
It seems that you put a lot of effort to make your work accessible! That's cool, but I'm afraid you did a bit of unnecessary work.
At first, semantic tags and their text content usually provides enough information for accessibility gadgets. Attributes like
role
and related to them, likearia-roledescription
, override initial roles of the elements, therefore they should be used only in a very rare cases when you can't use relevant tags. For example, when you work with some tricky custom elements or... mmm... your crazy boss have weird superstition abouta
tag, but you still need to explicit that element havelink
role. Sorry, a can't make up a serious example right now, but they exist =)Second, there is no need to wrap every tag in the
section
. It'll make your code more complex, less readable and could be cause of optimization problem.h1
,p
,img
and the others already have all the necessary semantic information and could be styled directly.But, really, that's cool that you tried to implement all this (I'd be too lazy =))
Oh, and since I'm already all chatty here, I can give you a couple advices:
- Use
rem
for font sizes. This value depends on user's font size settings and it's their primal purpose. - Keep styles and HTML in separate files. The bigger your project become, the less convenient it will be to maintain all like this.
- Try not to hardcode
height
andwidth
of your container. It's better when theheight
depends on content (it's defaultauto
value) and forwidth
you can use this trick:
main { width: 95%; max-width: 24rem; }
That way
main
will keep24rem
width on the big screens and will become95%
on the small ones.Well, I hope it could help =) You are doing great, good luck =)
Marked as helpful1@AStombaughPosted 5 months ago@Alex-Archer-I Thanks so much for your detailed feedback on my project! I had a tough time with the errors in the accessibility report but I did go through the docs and realized that I was doing too much. I think I reuploaded the project about 4 times before I finally got the errors to clear!
You're right about the section tags, they are excessive. I come from a graphic design background so I'm used to having layers and groups and with code I just haven't found anything outside of a section or div tag that helps me keep everything "grouped" so to speak.
Thank you again for all of the feedback, very much appreciated!!
1@Alex-Archer-IPosted 5 months ago@AStombaugh
Oh, I can understand you. I have a couple of flashbacks from my past attempts to comprehend photoshop about very structured psd layouts. Guess it's a bit different from a professional point of view though =)
Well, yeah, there are less cases when you need to group tags in HTML. It could be for semantical reasons - like, when you encounter some kind of list, you should use
ul
andol
with multipleli
inside. They may seems redundant, but still important.Or you have to wrap tags to change layout. For example, Greg Hooper and his avatar in this project should be wrapped in the flex element (it could be div, semantic tag are not necessary there).
So, glad I could help. Feel free to ask something if you need =) Random comments and suggestions are appreciated too, I have a lot to learn ahead and my works aren't perfect (yet) =)
Marked as helpful1 - Use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord