Design comparison
Solution retrospective
I would go for a cleaner CSS since once again I ended up using too many properties on all my selectors. I feel like the padding and margin properties could have been reduced to a single line or a couple of them, so I'll try to fix that.
What challenges did you encounter, and how did you overcome them?I was not really sure how to make the page responsive for mobile layouts without using media queries.
What specific areas of your project would you like help with?Making the layout responsive to shrink the container in size when browsing on mobile devices without media queries. Also, I'm under the impression that images don't show on the live site, so I'm not sure if I'm doing something wrong when calling the src on my index.html.
Community feedback
- @reteovPosted 6 months ago
One thing that might help would be to alter the
.card-container
element so that it has a maximum width of around 360 pixels. This will allow the project to fit the requirements, and leave a little room around the sides for the shadow and the background. From there, you can then adjust the font and image sizes to make the content of the container line up similar to how it looks in the screenshots.Marked as helpful0 - @danielmrz-devPosted 6 months ago
Hello there!
Congrats on completing the challenge! β
Your solution is really impressive!
I've got a couple of ideas (about how to use HTML better) that could make it even stronger:
π First: Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.π Second: Consider using
<h1>
for your main title instead of<div>
.It's more than just text size β it's about structuring your content effectively:
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
is for the most important heading.<h6>
is for the least important heading.- Stick to just one
<h1>
per page β it should be the main title for the whole page. - And don't skip heading levels β start with
<h1>
, then use<h2>
, and so on.
These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.
Hope that's helpful!
Keep up the great work!
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord