Design comparison
Solution retrospective
Finally completed my second challenge.
What challenges did you encounter, and how did you overcome them?nothing at this time
What specific areas of your project would you like help with?If there is something I should work on, please feel free to tell me, I would really appreciate your feedback.
Community feedback
- @0xabdulkhaliqPosted 7 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
BODY MEASUREMENTS 📐:
- Use
min-height: 100vh
forbody
instead ofheight: 100vh
. Setting theheight: 100vh
may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation
- For example; if we set
height: 100vh
then thebody
will have100vh
height no matter what. Even if the content spans more than100vh
of viewport.
- But if we set
min-height: 100vh
then thebody
will start at100vh
, if the content pushes thebody
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@wajasha02Posted 7 months ago@0xabdulkhalid Thank you for taking the time to review my code. It's very helpful for me. Next time, I will make sure to follow these steps.
0 - @scamgiPosted 7 months ago
Nice code bro! I would just add an
<a>
tag that contains the h2. The rest is clean codeMarked as helpful1@wajasha02Posted 7 months ago@scamgi Oops, I forgot about that, but thank you for reminding me.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord