Design comparison
Solution retrospective
- It was easy to do but as I'm getting back to coding I needed to remember some CSS rules
- Nothing!
- No
Community feedback
- @eniskrtPosted 10 months ago
Good job!
body{ min-height:100vh; display: flex; align-items: center; justify-content: center; }
You can use this block to get the card in the middle of the page.
Good code...
Enis
Marked as helpful1@mahmodltePosted 10 months agoThank you so much Enis @eniskrt I will make the changes to it
0 - @danielmrz-devPosted 10 months ago
Hello @mahmodlte!
Your solution looks great!
I have a couple of suggestions for improvement:
- First: In order to make your HTML code more semantic, use
<h1>
for the main title instead of<h2>
. Unlike what most people think, it's not just about the size and weight of the text.
π The
<h1>
to<h6>
tags are used to define HTML headings.π
<h1>
defines the most important heading.π
<h6>
defines the least important heading.π Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.- Second: Still about semantic HTML, use
<main>
to wrap the main content instead of<div>
.
All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0@mahmodltePosted 10 months agoHello @danielmrz-dev
Amazing I thought about the size first but now I will change it to h1 <h1> and change the text size using CSS. That is so important. lesson learned
that's so true I have to use main to improve HTML semantics to improve SEO and accessibility.
Thank you so much Daniel
0 - First: In order to make your HTML code more semantic, use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord