@Stroudy
Posted
Hello again, It is nice to see you taking the feedback I gave you and making changes, Fantastic effort on this! You’re really nailing it. Just a few things I noticed that could make it even better…
- On the last feedback I gave you, I mentioned about developers should avoid using pixels (
px) because they are a fixed size and don't scale well on different devices. Instead, useremorem, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.
Great job taking the time to learn! Your efforts are paying off, and I hope these insights guide you to even more success. Keep pushing forward, and remember, you’ve got this! Enjoy your coding adventures! 💪
Marked as helpful
@Marcod01
Posted
Hey @Stroudy thanks for the feedback just changed it from height: 450px; to height: 30em; weight: 330px; to weight: 20em;
@Stroudy
Posted
@Marcod01, Nice! Also consider using min and max are better than using only width or height because they provide flexible, responsive control over an element’s size. They allow elements to grow or shrink within defined limits, ensuring the design adapts to different screen sizes without breaking, maintaining usability and visual consistency.
Marked as helpful
