Design comparison
Community feedback
- @kaamiikPosted about 1 month ago
Hi. Some notes:
-
footer
should be outside the main as a sibling not a child. -
img
is decorative and no need to alt text and it should be empty likealt=""
-
Use
min-height:100vh
instead ofheight
-
For your
.badge
usep
tag that is more semantic. -
Your font-size should never be in
px
unit and you have to userem
instead. -
Your
h2
is interactive because hashover
effect. when an element has hover effect, then it should be interactive. So you have to wrap it betweena
orbutton
too. If It takes you to a new page then It'sa
and If doing an action then It'sbutton
. -
Use a proper CSS reset for your styles. Andy Bell has a good one.
Marked as helpful1@ckulloPosted 30 days ago@kaamiik Thank you for your feedback, I've updated the solution as you suggest.
0 -
- @Ramkumar492Posted about 1 month ago
Design and code output matches . Can concentrate on padding and margins. Good work
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord