Design comparison
SolutionDesign
Community feedback
- @StroudyPosted 3 months ago
Hey this is a great solution, Something you should be proud of 100%, A few things I noticed,
- Your heading elements are not in a sequentially-descending order,
<h4>``<h2>
, Should be<h1>``<h2>``<h3>``<h4>
, You can have multiple<h2>
but they have to be in order, Properly ordered headings that do not skip levels convey the semantic structure of the page, making it easier to navigate and understand when using assistive technologies. - Missing a
<meta>
description tag for SEO purposes, - It is best practice to have a
<main>
tag inside your body highlighting the main section. - Setting a height and width attribute to your
<img>
will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image, - You should avoid using
ID selectors #
and useclass=""
Instead because#ID
is usually used for JavaScript or other reasons not styling. - You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
- Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
- Using
max-width: 100%
ormin-width: 100%
is way more responsive then justwidth:100%
, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail. - You should avoid using
px
as it is an absolute unit and not a responsive unit likerem
orem
, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels. - Another great resource for px to rem converter.
I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻
0 - Your heading elements are not in a sequentially-descending order,
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord