Design comparison
Solution retrospective
I'm proud of solving some bugs without help, just with my own knowledge...Of course is not the best code but I guess is a good one.
What challenges did you encounter, and how did you overcome them?I was trying to save some lines and I remember something about 'Nesting' with this character '&'. I find it very helpful.
What specific areas of your project would you like help with?I'm still trying to improve the modularization, class naming and so.
Community feedback
- @MiloosN5Posted about 2 months ago
I think you are on the right track! Just a few recommends that can help you improve:
-
Use SASS/SCSS instead of CSS – SASS is a preprocessor scripting language that extends the capabilities of CSS.(source) However, browsers can't understand SASS directly, so it needs to be compiled into CSS.(source) One benefit of using SASS is that you can organize your code better, such as by grouping all article-related styles into a common wrapper.
- when you use CSS:
.article__type { background-color: var(--yellow); font-family: 'Figtree', sans-serif; ... } .article__title { font-weight: 800; &:hover { color: var(--yellow); cursor: pointer; } } .article__text { color: var(--gray-500); line-height: 150%; }
- with SASS/SCSS:
.article { &__type { background-color: var(--yellow); font-family: 'Figtree', sans-serif; ... } &__title { font-weight: 800; &:hover { color: var(--yellow); cursor: pointer; } } &__text { color: var(--gray-500); line-height: 150%; } }
-
Enhance your semantic HTML – I’ve noticed that you're already using some semantic elements like <section> and <article>. However, here are a few additional recommendations:
- put time inside <time>
<time dateTime='2023-09-23'>Published 23 Sep 2023
- put your image inside <figure>
<figure className='card__graphics'> <img /> </figure>
- put someone's (e.g. author) info inside <address>
<address className='card__author'> <img /> <span className='card__author-name'>...</span> </address>
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord