Design comparison
Solution retrospective
This is my first project, all feedback are welcome. Thank you.
Community feedback
- @rayaattaPosted 10 months ago
Hello ๐chirag-bishnoi, congratulations on completing your first FED challenge ๐
I have some suggestions for you.
1 Since the
.profile
image is not decorative you should fill its alt attribute with the name of the person on the image I eAlt="Greg Hooper"
2 I noticed
<div class="wrapper">
replace it with<section class="wrapper">
in order to make your html more semantic.div
s do not carry any semantic value. They are used solely for decorations. You should replace some of them with tags such as<article>
and<section>
You can find out more about these tags and more in this article๐.I hope this helps ๐
Otherwise nice solution ๐
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord