@danielmrz-dev
Posted
Hello there!
Congrats on completing the challenge! ā
Your solution is really impressive!
I've got a couple of ideas (about how to use HTML better) that could make it even stronger:
š First: Think about using <main> to wrap your main content instead of <div>.
Imagine <div> and <span> in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.
š Second: Consider employing <h1> to <h6> tags for headings rather than using <p>.
The <p> tag is primarily intended for paragraphs. When it comes to headings, HTML offers us a range of heading tags: from <h1> to <h6>.
Here's a quick guide on how to use them:
- The
<h1>to<h6>tags are used to define HTML headings. <h1>is for the most important heading.<h6>is for the least important heading.- Stick to just one
<h1>per page ā it should be the main title for the whole page. - And don't skip heading levels ā start with
<h1>, then use<h2>, and so on.
It's more than just text size ā it's about structuring your content effectively.
These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.
Hope that's helpful!
Keep up the great work!
Marked as helpful
@ashap-bappy
Posted
Hi, @danielmrz-dev
Thanks for your valuable feedback. I will adjust my HTML according to your suggestion.
One more thing to clarify, when I slide the Solution-Design slider, my Solution is looking smaller than the Design given.
Can you give me some suggestion on how can I make it the same size?
@danielmrz-dev
Posted
@ashap-bappy
If I'm not mistaken, this project comes with a figma design file, where you can find the exact measures of the card.
Or you can use a browser extension called Perfect pixel, which might help you the same way.
Marked as helpful
@ashap-bappy
Posted
@danielmrz-dev
I've updated the solution with the help of your suggestions. I also changed the approach of my CSS implementation. This time It was lot easier to implement. Would you please review my solution and give some feedback on where I can improve further?
