P
Vasu Vallabh• 190
@coding-vasu
Posted
Overall Looks Good !
Feedback on Your Solution
Accessibility
- The
alttag is blank for the "Card-autho" image. Always include descriptive alt text for images to improve accessibility.
- You've set the base font size to 62.5%, which results in a 10px base font size.
- While this works for this project, it may cause issues when:
- Integrating design system libraries
- Following general web standards (16px is typically used as the base font size)
The following interactive states are missing from your solution:
- Tab index
- Focus state
- Hover state
- Active state
Consider adding these to improve user interaction and accessibility.
- The challenge specifies that font sizes should be slightly smaller on smaller screens.
- To achieve this, you can simply update the base font size to a smaller value for mobile breakpoints.
- Your current solution doesn't adapt the font size for smaller screens, affecting its responsiveness.
Use media queries to adjust the base font size for different screen sizes. This will help make your design more responsive without needing to change individual element sizes.
Marked as helpful
0
