Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Blog preview card using flexbox

@fibradiarta

Desktop design screenshot for the Blog preview card coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


  • Is the method I use good enough?, if not can you give advice so that in the future I can use the technique you suggest

Community feedback

Daniel 🛸 44,230

@danielmrz-dev

Posted

Hello @fibradiarta!

Your solution looks great!

I have a couple of suggestions for improvement:

  • In order to make your HTML code more semantic, and since that is the main title of the screen, you can replace the <h3> with <h1>. Unlike what most people think, it's not just about the size and weight of the text.

The <h1> to <h6> tags are used to define HTML headings. <h1> defines the most important heading. <h6> defines the least important heading. Only use one <h1> per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with <h1>, then use <h2>, and so on.

  • Also, still about semantic HTML, replace your div.container with main.container too.

All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.

I hope it helps!

Other than that, great job!

Marked as helpful

0

@Blackpachamame

Posted

This looks very good, I can only mention a few things:

  • You can apply display: block in your img to remove the white space generated below the image
  • You can apply max-width: 100%; instead of defining a fixed width. This way your image will adapt itself to the width of the container
  • Texts should be p or headings like h1, h2, etc. But you shouldn't just put them inside a div. An example to make it better understood:

This is wrong ❌

<div class="date">Published 21 Dec 2023</div>

This is good ✅

<div class="content">
    <h3>HTML &amp; CSS foundations</h3>
    <p>These languages are the backbone of every website, defining structure, content, and presentation.</p>
</div>
  • Do not use br to leave a space between texts, instead you can use margin-bottom or margin-top if necessary

Marked as helpful

0

@fibradiarta

Posted

Thank @Blackpachamame for the feedback will update the code

2

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord