Design comparison
Solution retrospective
Here is my solution for the blog preview card Any feedback at all will be highly appreciated
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @emjayruka!
Your solution looks great!
You're just missing the card's
box-shadow
. But it's very easy to create it. You just need to add this to themain.container
:box-shadow: 10px 10px 0 black;
I hope it helps!
Other than that, excellent job!
0 - @hassanmoaaPosted 9 months ago
Hello @emjayruka!
Great Job solving the challenge mate congrats š
Some suggestions for improvements.
For the font-size it's is better to use rems and ems but px for this project is no big deal.
font-size: 13px;
-
i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:
-
Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.
Which properties are affected?
All of these properties must never ever be declared in pixels:
- font-size
- line-height
- letter-spacing
If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!
- You should use ems, and rems for font-sizes would be better
This article may help:
https://fedmentor.dev/posts/font-size-px/
āāāāāāāā
Other than that all good!
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord