Blog preview card using flex

Community feedback

• 

  Svitlana Suslenkova•5,320

  @SvitlanaSuslenkovaPosted about 2 months ago

  div.learning - could be <p> or <h> element. Divs are mostly used as containers for other elements, not for text.

  Span- it's inline element. You use it when you want to add it in the same line with another element. As it's only element for the line, it's better to use block element (<p> or <h>)

  Marked as helpful

  2

  ---

  

  Alingggg•130

  @AlinggggPosted about 2 months ago

  @SvitlanaSuslenkova

  Noted. Thank for the feedback! I still have to work with my semantics.

  0
• 

  P

  Steven Stroud•11,890

  @StroudyPosted about 2 months ago

  Awesome job tackling this challenge! You’re doing amazing, and I wanted to share a couple of suggestions that might help refine your approach…

  • These <span> should really have semantic tags like headings (<h1> to <h6>) and paragraphs (<p>) convey structure and meaning to content, improving accessibility, SEO, and readability by helping search engines and screen readers interpret the content.<span class="date">Published 21 Dec 2023</span> <span class="name">Greg Hooper</span>

  • Using font-display: swap in your @font-face rule improves performance by showing fallback text until the custom font loads, preventing a blank screen (flash of invisible text). The downside is a brief flash when the font switches, but it’s usually better than waiting for text to appear.

  • Developers should avoid using pixels (px) because they are a fixed size and don't scale well on different devices. Instead, use rem or em, which are relative units that adjust based on user settings, making your design more flexible, responsive, and accessible. For more information check out this, Why font-size must NEVER be in pixels or this video by Kevin Powell CSS em and rem explained.- Another great resource for px to rem converter.

  • Using max-width: 100% or min-width: 100% is more responsive than just width: 100% because they allow elements to adjust better to different screen sizes. To learn more, check out this article: responsive-meaning.

  You’re doing fantastic! I hope these tips help you as you continue your coding journey. Stay curious and keep experimenting—every challenge is an opportunity to learn. Have fun, and keep coding with confidence! 🌟

  Marked as helpful

  1

  ---

  

  Alingggg•130

  @AlinggggPosted about 2 months ago

  @Stroudy

  I really have to keep this in mind having read these tips a couple times already hehe. Thanks for the feedback!

  1

  

  P

  Steven Stroud•11,890

  @StroudyPosted about 2 months ago

  Hey @Alinggg, Its nest to build a strong foundation, So take your time and experiment, See what works what dont, Ask questions. I hope to see more from you soon!

  0
• 

  MikDra1•6,920

  @MikDra1Posted about 2 months ago

  Well done, here are some things to review 😊:

  • REM for Units: It's best to use rem for all units instead of px, as this ensures scalability and consistency in spacing and font sizes based on the user's root font size. It helps improve accessibility.

  • Semantic HTML: Consider ensuring all elements are wrapped in semantic HTML tags like <main>, <section>, and <article> to enhance the structure and SEO-friendliness of the page.

  • BEM/Convention for Class Naming: Apply a class naming convention like BEM (Block Element Modifier) to make the styles modular and more maintainable. For example, use .card__title or .card--highlighted.

  • CSS Reset: Consider adding a full modern CSS reset (like normalize.css or custom resets at the beginning of the stylesheet) to ensure consistent styling across different browsers. Here is a link to one I really like.

  • Clamp() for Responsiveness: Use the clamp() function for fluid typography and spacing, allowing elements to resize smoothly between a minimum and maximum value based on the viewport size (e.g., font-size: clamp(1rem, 2vw, 1.5rem)).

  • Responsive Card: To make the card responsive, ensure the layout uses flex or grid combined with max-width instead of fixed width values. This will make the design more flexible and adapt better to different screen sizes.

  • Use max-width/min-width and max-height/min-height: Instead of using fixed width and height, opt for max-width or min-width to allow the elements to resize smoothly on different screen sizes, improving overall responsiveness.

  Hope you found this comment helpful 💗💗💗

  Good job and keep going 😁😊😉

  Marked as helpful

  0