Design comparison
Solution retrospective
Most proud of using sole flex, rather than grid like my previous challenge. As well as the time it took me to finish. Next time, I'd like to further improve my skills at accurately replicating sizing from the designs.
What challenges did you encounter, and how did you overcome them?Struggled getting the card to align centered vertically using align-items, overcame this by doing some research and realising I needed to define a height of the parent container.
What specific areas of your project would you like help with?I'd like any general tips on how to improve this, if there is any more elegant solutions to what I've done.
Community feedback
- @erratic-enigmaPosted 8 months ago
Hi, good work on this project! Here's some improvements I would suggest:
The
.published-date
should be ap
element rather than adiv
, ideally with the date wrapped in atime
element.Give the
body
element amin-height
of100vh
rather than aheight
. You should generally avoid using a fixed height on elements containing text, including thebody
.The
.card
has awidth
set in pixels. This causes horizontal scrolling on smaller viewports. Use amax-width
instead (ideally in rems) so the card shrinks in size on smaller viewports.The
.card
being set todisplay: flex
is redunant and can be removed.Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord