Blog Preview Card

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello @pohyongzhi!

  Your project looks great!

  I just have a suggestion about semantic HTML:

  • Try using more the HTML semantic tags: For example, use main for the main content instead of a div and use h1, h2, h3, h4, h5, h6 for headings instead of p. This changes may have a little visual impact (that can be solved with CSS) but makes your HTML code more semantic and improves SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, you did an excelent job!

  0
• 

  Ranit Manik•880

  @RanitManikPosted 11 months ago

  i see couple of problems with your code

  • All content should be contained within landmarks. Every page minimally needs a main element
  • publish date could go inside a time element as well, that's worth reading about
  • NEVER ever ever ever write font size in px! I suggest you to read this article . Line height and letter spacing must also not be in px. use rem for all font related properties.
  • The body should never have it's height limited, just as no text containing elements should have their height limited. Instead of height 100vh on the body, use min-height
  • According to the card design challenge, the shadow of the card should grow on hover, but in your case, that is missing.

  0