Design comparison
Solution retrospective
feel free to give feedback only CSS and HTML used
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @sefaonder!
Your solution looks great!
I have a couple of suggestions (about semantic HTML) for improvement:
π First: Use
<main>
to wrap the main content instead of<section>
.The tag
<section>
would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.π Second: Use
<h1>
for the main title instead of<h2>
.Unlike what most people think, it's not just about the size and weight of the text.
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
defines the most important heading.<h6>
defines the least important heading.- Only use one
<h1>
per page - this should represent the main heading/title for the whole page. And don't skip heading levels - start with<h1>
, then use<h2>
, and so on.
All these tag changes may have little or any visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord