Blog preview card

Community feedback

• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 11 months ago

  Hey there, well done! Here are my suggestions.

  HTML:

  • You need a <main>, this is important for accessibility. You can change .card into a <main>.

  • The images don't need the srcset attribute.

  • The profile image must have descriptive alt text.

  • .attribution should be a <footer>.

  • Footer text needs to be wrapped in a <p>.

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • You don't need media queries on this challenge, as the design stays the same. When you do need them, they should be in rem instead of px. Also, remember that setting fixed widths, like width: 350px is rarely a good idea.

  • Do add a max-width in rem, to prevent the card from getting too wide on larger screens.

  Marked as helpful

  1

  ---

  

  Laureano•880

  @ScreamPunk27Posted 11 months ago

  @Islandstone89 Thank you for the advice.

  1