@Code-Beaker
Posted
Hi there, congratulations on completing this challenge. You've done a great work with this challenge! 🎉
I would like to share some of my suggestions regarding your website that might help you improve it.
- This is optional, but having a small
transition
would improve thebox-shadow
hover effect of the card. - The heading levels should only decrease by one or if you're using an
h1
in your document, then the next heading must be anh2
. I noticed this issue with your document here:
<div class="card">
<h2 class="card-title">HTML & CSS foundations</h2>
<div class="user-details">
<img src="assets/images/image-avatar.webp" alt="User Image" />
<h6>Greg Hooper</h6> <!-- The heading level jumps from h2 to h6 -->
</div>
</div>
When you're aiming to create a small text element, either use a p
tag or style a heading using CSS. That might be a better option. If you wish to learn more about this, read this StackOverflow Page
Overall, you've done an impressive work. These small changes would make it more accessible and visually better.
Hope this helps you. 😃
Marked as helpful
@Code-Beaker It indeed helped, I have added a transition to the card element, and followed the semantic guideline. you can go over it again.
@Code-Beaker
Posted
Glad I was able to help, @Marvie-03
I noticed an issue with the image. This might be due to the max-width: 100%
that is applied to the img
.
I tried editing the styles of the .card
with my developer tools and changed the max-width: 20rem
and it seems fine. The improvements you've made are noticeable. Good job 😊