Blog Preview Card Solution

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 4 months ago

  Hey there! 🙋🏽‍♂️

  Congrats on completing the challenge! ✅

  Your project looks fantastic!

  Here's a tip to make it even better:

  Using margin and/or padding isn't always the best way to center an element. Try this super efficient method to center an element vertically and horizontally:

  📌 Apply this CSS to the body (skip position or margins to make it work correctly):

  body {
      min-height: 100vh;
      display: flex; 
      justify-content: center;
      align-items: center;
  }
  

  Hope this helps!

  Keep up the great work!

  Marked as helpful

  0

  ---

  

  Jerico Jones B. Edic•30

  @0653JericoPosted 4 months ago

  @danielmrz-dev Thank you so much sir, will surely read about that, understand it and apply it.

  1
• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @0653Jerico

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it. You can achieve your dreams!

  Things I like about your solution 🎉

  • Good start with responsiveness
  • Use of some semantic HTML elements
  • Clear descriptive CSS classes

  Things you could improve ✍️

  • Add a bit of padding to your body element so the card has room to breath on smaller viewports. You could also add min-height: 100vh so the body takes up 100vh while still being able to grow.

  body {
      background: hsl(47, 88%, 63%);
      padding-inline: 2rem;
      min-height: 100vh;
  }
  

  • Try using CSS variables they make your values more reusable.

  • I see you use padding: none here:

  * {
      margin: 0;
      padding: none;
      box-sizing: border-box;
      font-family: "Figtree";
  }
  

  This is not a valid value for padding. Try using padding: 0.

  • You could experiment with Flexbox and center your card.

  • You have a fixed width and height on your container, this will cause overflow issues when the content in your container gets too big.

  I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  0

  ---

  

  Jerico Jones B. Edic•30

  @0653JericoPosted 4 months ago

  @DylandeBruijn Thanks for the notice sir, and will surely apply these. Also, I don't quiet get the fixed width and height. How should I fix that sir?

  0

  

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @0653Jerico

  See the updated code:

  .container {
      max-width: 300px;
      background-color: hsl(0, 0%, 100%);
      margin: 10% auto 2%;
      padding: 1.5em;
      border: 1px solid;
      border-radius: 1.5em;
      box-shadow: 10px 10px hsl(0, 0%, 7%);
  }
  

  This will make your card a bit responsive by default as well.

  You can update the image too:

  img {
      border-radius: 0.7em;
      max-width: 100%;
      margin-bottom: 1em;
  }
  

  0