Design comparison
SolutionDesign
Solution retrospective
Any feedback is appreciated! :D
Community feedback
- @danielmrz-devPosted 10 months ago
Hello Michael!
Your solution looks excellent!
I have just one suggestion:
- Use only
main
for the main content in this case. The tagarticle
would make more sense if the card was part of a bigger website (it certainly would in real world), but here it's all we have on the screen.
Other than that, you did an excellent job!
I hope it helps!
Marked as helpful0 - Use only
- @BlackpachamamePosted 10 months ago
¡Saludos Michael! has hecho un gran trabajo, el diseño se ve idéntico.
Puedo sugerirte que, para centrar el contenido lo hagas directamente desde el
body
y elimines esemain
dejando solo elarticle
y elfooter
(attribution)body { background-color: var(--yellow); min-height: 100vh; display: flex; justify-content: center; align-items: center; flex-direction: column; gap: 20px; }
También puedes agregarle el atributo
alt
a las imágenes con una breve descripción por temas de accesibilidad. El resto esta correctísimo 😎Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord