Blog Preview Card simple solution

Community feedback

• 

  P

  Sven Notermans•160

  @Sven-27Posted 4 months ago

  Hi,

  First of all it looks good wath you did. Couple suggestions i have.

  IN your html you use mainly div. Try to use semantic elements as much as possible. Div is used when no other element is suited. Like <div class="footer"> You can do <footer> instead.So it is a good thing to learn more about them. Otherwise it looks good.

  CSS: I see that you have imported the fonts directly. Since they are already in de asset folder it proberly was the meaning to use them instead of importing.Look at 'font face' to use local fonts in your project. The use of variables is perfect.

  You didn't make the fonts responsive. Try to google how to make the fonts responsive without media query. That was part of the assignment. Try to structure your CSS the same as your html. I will give you my github link so you can see what i mean.

  Take a look at your hover on the h2. It does not turn yellow.

  Hope you can use this feedback and if you have questions you can always ask me either here or on discord.

  My github is https://github.com/Sven-27/blog-preview-card

  Regards Sven

  Marked as helpful

  0

  ---

  

  ShadowCoder040•70

  @ShadowCoder040Posted 4 months ago

  @Sven-27 Hi Sven, thank you so much for the feedback. I see in your CSS file that it could be the clamp value to make the font-size responsive, right? I'll have to look into that. Frankly, I overlooked that the h2 should have a hover state. Regarding the fonts, I seemed to have an issue with figuring out to use the exact fonts as given in the file somehow. Mine look similar but not the same. Looking at your CSS file, I haven't seen this @font-face approach, so I might have to look into that as well. I just started with HTML and CSS a couple weeks ago, and last week started testing my knowledge with these challenges here. Always appreciate feedback on my code, thanks for that! Have a good day.

  0

  

  P

  Sven Notermans•160

  @Sven-27Posted 4 months ago

  @ShadowCoder040 No problem.

  We are here to help eachother. And if you started just a couple of weeks ago, you really did an awesome job already. If you have questions just ask.

  0