Design comparison
SolutionDesign
Solution retrospective
Any feedback would be appreciated
Community feedback
- @BlackpachamamePosted 11 months ago
Greetings! you have done a great job š
š Some accessibility and semantics recommendations for your HTML
- To improve the semantics of your HTML, you can change your
<div class="card">
to a<main class="card">
- You can apply
display: block
to the image to remove the white space generated underneath. Although visually in this case it is irrelevant, it helps you better calculate the space with other elements - The
img
of the banner does not occupy the corresponding width because you applied aheight: 100%
. To fix it, you can leave theheight: auto
, addmax-width: 100%
. Next, remove theheight
andwidth
from yourthumbnail
class - For some reason the font you are calling is not applied and gives an error
0@lucasfernandodevPosted 11 months ago@Blackpachamame "Thank you very much for the feedback; the positioning of the thumbnail image really locked me up. The font path is incorrect, so it's not working."
1 - To improve the semantics of your HTML, you can change your
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord