Design comparison
Solution retrospective
I started this morning and completed it in one day. I think it is something to be proud of. As I am currently learning and improving along the way maybe next time I'll use a framework to improve my code.
What challenges did you encounter, and how did you overcome them?I did encounter so many difficulties this time because this challenge is in the same rhythm as the last one. The only thing I had to deal with was my error while writing the CSS but thanks to the DevTool, I managed to solve it.
What specific areas of your project would you like help with?I need some advice on how to center the card because I used height: 100vh;
for the height of the body then when centering the card I used margin: 50% auto;
but It did work as I expected it to. Please let me know if there is anything else I did wrong in my code.
Community feedback
- @noormuhammadrazaPosted 5 months ago
For centering the card you could apply display: grid; and place-items: center; to the container of the card along with height 100vh.
You have done a great job considering you have completed it in a single day and you are improving day by day. So keep up the good work.
As for imrovements and suggestion there are few things I would like to share with you.
- Try to use divs instead of uls it would be much easier to work with them and they are semantically more appropriate in this project's scenario.
- The project comes with downloaded fonts. Next time make sure you learn how to use them because sometimes google fonts can cause issues due to network connectivity.
- Finally make sure to analyze more closely and match the design as much as possible.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord