Design comparison
Solution retrospective
I am not sure if I used media queries and CSS variables in a way that would be chosen in professional projects as well or if a different approach works better in terms of organization of the CSS and maintainability.
Community feedback
- @DylandeBruijnPosted 4 months ago
@cmdaltent
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution π
- Use of semantic HTML elements
- Clear descriptive CSS classes
- Use of CSS custom properties
Things you could improve βοΈ
-
I suggest adding a bit of
padding
to yourbody
element so the card has some space around it on smaller viewports. -
You could add a
min-height: 100vh
to yourmain
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows. -
Try using using relative CSS units like
rem
andem
they make your layout more adaptable. -
You donβt have to wrap your image in a separate
div
, itβs possible to style it directly to achieve the same result. -
I would then change the styles of your image to this:
{ display: block; max-width: 100%; width: 100%; border-radius: 10px; }
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful0 - @Evgeniy-HozyainovPosted 4 months ago
The provided HTML code is a great example of well-structured and semantically correct markup. The CSS used in the code is concise and well-organized, with clear class names that make it easy to understand and modify the styles. Overall, the code demonstrates a solid understanding of HTML and CSS best practices.
0 - @javontrlrobertsPosted 4 months ago
Looks pretty spot on! Maybe add a hover state to the box-shadow with transition for effect? Otherwise great job!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord