Design comparison
SolutionDesign
Solution retrospective
your feedbacks are welcomed :)
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @badrEladraoui1!
Your project looks very good!
I have a few suggestions for improvement:
-
Avoid setting specific
width
values for the container. Add the content first and the container will adapt its size to fit the content inside. -
I noticed that you used
margins
in order to place the card in the middle of the page. There are two better ways to center elements:
You can apply this to the body (in order to work properly, don't use
position
ormargins
):body { height: 100vh; display: flex; justify-content: center; align-items: center; }
or you can apply this to the element you wanna center:
.element { position: absolute; top: 50%; left: 50%; transform: translate(-50%, -50%); }
I hope it helps!
Other than that, you did a great job!
Marked as helpful1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord