Blog preview card

Community feedback

• 

  P

  Øystein Håberg•10,710

  @Islandstone89Posted 4 months ago

  Good job!

  Here are some tips:

  HTML:

  • As this is a blog card, the heading would have a link inside.

  • I would wrap the date in a <time> element:<p>Published <time datetime="2023-12-21">21 Dec 2023</time></p>.

  • Screen readers announce images as "image" by default, so you would not include words like "image" or "photo" in the alt text.

  • .attribution should be a <footer>, and you should use <p> for the text inside.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I like to add 1rem of padding on the body, to ensure the card doesn't touch the edges on small screens.

  • On the .container, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

  • Except for the profile image, remove all widths.

  • Add a max-width of around 20rem on the card, to prevent it from getting too wide on larger screens.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  Marked as helpful

  0