Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
Being able to put the layout down and execute it properly, I would like to improve upon my time that i take to make such app.
What challenges did you encounter, and how did you overcome them?challenges weren't that blocking for me i could pass by most of them without much help.
Community feedback
- @SamOwensPosted 4 months ago
Looks pretty good. Just a few very minor things
- If possible you should use rem values for sizes as opposed to px.
- You don't really need the surround div, so it would be considered DOM bloat.
- You'd be better off giving the images their own class rather than using their wrapper to target them but again, very very minor.
- The padding over the SVG looks a bit off
1@shinzenkoPosted 4 months ago@SamOwens Hey thanx man I agree with all the points the last one though in my Pc it showed that the padding on top was little more than intended so i had to reduce it at top but once I deployed it i realised i shouldnt have reduced it, anyway noted about the other issues.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord