Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

blog-preview-card-main

@yiorgosbagakis

Desktop design screenshot for the Blog preview card coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I open the design files on Figma to get accurate measurements this time.

Then I used https://tachyons.io/ for the css classes and then I used the minimum amunt of custom css classes that I created in my style.css stylesheet. I will continue using Tachyons since this leads to much cleaner code and it is also easy to use.

What challenges did you encounter, and how did you overcome them?

Started using Tachyons css classes.

What specific areas of your project would you like help with?

I would like feedback about semantic html use and acessibility.

Community feedback

Huy Phan 1,840

@huyphan2210

Posted

Hi, @yiorgosbagakis

I reviewed your solution and have a few thoughts to share:

  • I recently addressed a similar issue in the same challenge for @Shankarganesh-B. You can check out my response there, but I’d like to dive deeper into your specific case.
  • I believe Frontend Mentor provides feedback on certain aspects of your HTML when you submit your solution. It may be flagging that the body should include elements like header, main, or footer. In your case, your article could serve as the main element, and the .attribution could be better suited as a footer.
  • I noticed the image is wrapped in a div without a class. You might consider using a <picture> element instead for more semantic flexibility.
  • For wrapping the word "Learning," it could be more appropriate to use a span rather than a div since it’s likely an inline element.
  • Nice work using the time tag! I hadn’t thought of that before. However, since it seems to be a label for the h1 heading, it might make sense to wrap the time element in a label. I encourage you to look into the relationship between label and heading elements like h1 and h2.
  • Lastly, I recommend focusing on mastering pure CSS before diving into any CSS libraries (like Tachyons). This will give you a solid foundation and help you understand how libraries build on CSS concepts.

Remember, these are just suggestions and not absolute rules. There might be other approaches that work just as well or even better.

Hope this helps!

0

@yiorgosbagakis

Posted

Thanks a lot @huyphan2210 your comments are very useful and appreciated!

1

@Shankarganesh-B

Posted

Would appreciate if someone could help me with optimizing my codes for better readability.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord