Design comparison
Solution retrospective
I am proud of developing my search skills to overcome the problems I face.
Community feedback
- @defPhisyPosted 4 months ago
Great Job.
To make your html more semantic u can use instead of
<div>
elements like<article>, <header>, <footer>, <main>
, ... There is a good overview on w3schools.I think you can improve your css-reset. For example omit
padding: 0;
on the star selector for your css reset. I read fantasstic articles form Josh Comeau and Andy Bell about modern css reset. Made my own css-reset.css based on theses articles in this project.Another great advise i got: Why font-size must NEVER be in pixels
Hope i could help you a bit. Keep going ;)
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord