Design comparison
Solution retrospective
feedback are welcome
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @ExiviuZ!
Your solution looks great!
I have a couple of suggestions for improvement:
- For semantic reasons, and since that is a heading and the main title of the screen, you can replace the
<p>
with<h1>
.
The
<h1>
to<h6>
tags are used to define HTML headings.<h1>
defines the most important heading.<h6>
defines the least important heading. Only use one<h1>
per page - this should represent the main heading/subject for the whole page. Also, do not skip heading levels - start with<h1>
, then use<h2>
, and so on.- Also, still about semantic HTML, you can replace your
div.container
withmain.container
.
All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO optimization as well as the accessibility of your project.
- Lastly, add
cursor: pointer;
to the title to indicate that's a clickable element.
I hope it helps!
Other than that, great job!
0 - For semantic reasons, and since that is a heading and the main title of the screen, you can replace the
- @BlackpachamamePosted 11 months ago
Good job!
Here are some comments that may help you:
- Use semantic tags such as
main
,footer
,figure
, etc, this helps the accessibility and SEO of the site - The
<div class="card">
should be<main class="card">
- The
<div class="title extra-bold">
should be<h1 class="title extra-bold">
- The
<div class="author">
should be<footer class="author">
- Apply
display: block
to the image to remove that annoying white space
0 - Use semantic tags such as
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord