Blog Preview Card made using HTML CSS

Community feedback

• 

  Boris•2,850

  @mkborisPosted 3 months ago

  Nice work AndreChips, here are a few things to review

  • All content should be wrapped within landmarks. Wrap a main tag around .card-container
  • It's not good practice to wrap every element in div because divs aren't semantic. The .card-title should be a Heading element. Every page should have at least one heading typically an h1 element to provide a clear structure. The other texts should be paragraph elements p.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
  • Media queries should be defined in rem not px
  • Avoid setting fixed heights and widths on elements, as this can create problems with responsiveness and content fit. Instead, let the content and padding determine the element’s size. If necessary, use max-width or min-height, and prefer relative units like rem for better adaptability. Change the width of the .card-container to max-width and it should be defined in rem. Also remove the height completely and use padding within the container to give it some room.

  Hope this helps

  Marked as helpful

  0