Boris• 2,870
@mkboris
Posted
Nice work AndreChips, here are a few things to review
- All content should be wrapped within landmarks. Wrap a
main
tag around .card-container - It's not good practice to wrap every element in
div
because divs aren't semantic. The .card-title should be a Heading element. Every page should have at least one heading typically anh1
element to provide a clear structure. The other texts should be paragraph elementsp
. - Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
- Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
- Media queries should be defined in
rem
not px - Avoid setting fixed
heights
andwidths
on elements, as this can create problems with responsiveness and content fit. Instead, let the content andpadding
determine the element’s size. If necessary, usemax-width
ormin-height
, and prefer relative units likerem
for better adaptability. Change thewidth
of the .card-container tomax-width
and it should be defined inrem
. Also remove theheight
completely and usepadding
within the container to give it some room.
Hope this helps
Marked as helpful
0