Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Blog Preview Card made using HTML CSS

@AndreChips

Desktop design screenshot for the Blog preview card coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I wouldn't do anything differently, except if what I made was wrong.

What challenges did you encounter, and how did you overcome them?

No challenges.

What specific areas of your project would you like help with?

Layouting the CSS probably

Community feedback

Boris 2,870

@mkboris

Posted

Nice work AndreChips, here are a few things to review

  • All content should be wrapped within landmarks. Wrap a main tag around .card-container
  • It's not good practice to wrap every element in div because divs aren't semantic. The .card-title should be a Heading element. Every page should have at least one heading typically an h1 element to provide a clear structure. The other texts should be paragraph elements p.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
  • Media queries should be defined in rem not px
  • Avoid setting fixed heights and widths on elements, as this can create problems with responsiveness and content fit. Instead, let the content and padding determine the element’s size. If necessary, use max-width or min-height, and prefer relative units like rem for better adaptability. Change the width of the .card-container to max-width and it should be defined in rem. Also remove the height completely and use padding within the container to give it some room.

Hope this helps

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord