Design comparison
Solution retrospective
I have a good understanding of HTML and CSS, but any suggestions would be appreciated. Thanks
Community feedback
- @MelvinAguilarPosted 10 months ago
Hello there 👋. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML 🏷️:
- Wrap the page's whole main content in the
<main>
tag.
CSS 🎨:
- Instead of using pixels in font-size, use relative units like
em
orrem
. The font-size in absolute units like pixels does not scale with the user's browser settings. Resource 📘.
- Use
min-height: 100vh
instead ofheight
. Setting the height to 100vh may result in the component being cut off on smaller screens, such as a mobile phone in landscape orientation.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1@Jack-OCPosted 10 months agoThanks for the response and help, I’ll look to make some changes to improve my solution.
0 - Wrap the page's whole main content in the
- @techyjcPosted 10 months ago
Nicely Done.
Just FYI.
Check out Kevin's YT channel you'll fint some great content and tutorials. https://www.youtube.com/@KevinPowell
Great job!
Marked as helpful0 - @techyjcPosted 10 months ago
Hi Jack,
Apologies, I did write a more detailed initial response. but then decided to delete the majority of it after reviewing your code again. So, I realised my comment didn't really make any sense.
Nice work!
0@Jack-OCPosted 10 months agoNo worries. Thank you for the suggesting Kevin’s youtube channel, I’ll definitely be taking a look. @techyjc
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord