Design comparison
Community feedback
- @glowri57Posted about 2 months ago
Hi Minagamingotaku52
This is a good work you should be proud of, here's a few things I noticed:
- It is best practice to use
margin-inline: auto;
to center left and right then than justmargin: auto;
You can center the height by using this code snippet:
min-height: 100svh; display: flex; justify-content: center; flex-direction: column;`
-
Your code couldn't display as a live page. You could try to re-deploy on netlify, vercel or github pages.
-
You should rewrite your readme template using the guidelines given to you. The README is there to guide people going through your project and give them an understanding of what you did in your project.
-
Try to use the fonts, font weights and colors given to you in the style guide. The essence of the project is to ensure that your work look like the design given in the design folder in this project.
I hope you found some of this information helpful, Happy coding! 💻
0 - It is best practice to use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord