Design comparison
Solution retrospective
i try <3
Community feedback
- @jerry-the-kidPosted 9 months ago
Hi Alexandre Shin,
I wanted to commend you on your exceptional work, particularly the captivating shadow animations in the background. However, I noticed a minor issue in your code that I believe could be improved upon.
In your card implementation, you've specified a height attribute. While this doesn't necessarily break functionality, it's generally considered a bad practice. The reason being, when you set a fixed height for an element, it can lead to content overflow if the content within the element exceeds this predefined height.
A more advisable approach would be to allow the height of the element to adjust dynamically based on its content. By omitting the height attribute, the element's height will naturally expand or contract to accommodate its content, ensuring a more flexible and robust design.
Keep up the great work, and I hope this feedback proves helpful in refining your code further.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord