@danielmrz-dev
Posted
Hello @Theosaurus-Rex!
Your solution looks excellent!
I have a couple of suggestions:
- First: Use
mainto wrap the main content instead ofmainandarticle.
š The tag article would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.
This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
- Second: Since the title is a clickable element, it's nice to add
cursor: pointerand a color shift ashover effect.
š This gives the user a visual indication that the element is clickable, as obvious as it may look.
I hope it helps!
Other than that, great job!
Marked as helpful
@Theosaurus-Rex
Posted
@danielmrz-dev
Hey Daniel, thanks so much for your feedback! That makes a lot of sense regarding the article tag - I guess I was approaching it like I would approach building a reusable component for a larger page, but it makes sense to treat it differently in this case! I'll apply your suggestions and update my solution š
@danielmrz-dev
Posted
@Theosaurus-Rex
I'm glad I could help! š
