Blog Preview Card HTML + CSS

Community feedback

• 

  Hassan Moataz•1,860

  @hassanmoaaPosted 9 months ago

  Hello !

  Great Job solving the challenge mate congrats 🎉

  Some suggestions for improvements.

  For the font-size it's is better to use rems and ems.

  font-size: 13px;

  • i see you using pixels for many elements, never use pixels for font-sizes in any element, here's why:

  • Certain font-related CSS properties will render your site completely inaccessible if their value is declared using pixels even once.

  Which properties are affected?

  All of these properties must never ever be declared in pixels:

  • font-size
  • line-height
  • letter-spacing

  If you've used pixels to define any of the above style properties, these will not respect the user's font size preferences!

  • You should use ems, and rems for font-sizes would be better

  This article may help:

  https://fedmentor.dev/posts/font-size-px/

  ➖➖➖➖➖➖➖➖

  Heading is defined with <h1> to <h6> tags. It is important to use headings to show the HTML document structure.

  <h1> headings should be used for main headings, followed by <h2> headings, then <h3>, and so on up to <h6>

  Other than that you're good, keep up the good work!

  Marked as helpful

  1

  ---

  

  dbmourits•60

  @dbmouritsPosted 9 months ago

  @hassanmoaa thanks for the comprehensive response. I will try to implement your suggestion in my future projects. I was misled by the link, normally I would choose this text (biggest text) as H1, but now I choose the <a> tag, never thinking to combine the two like <h1><a>…</a></h1>.

  I really appreciate al the feedback I get on this website.

  Thank you very much.

  1