Boris• 2,870
@mkboris
Posted
Great work AkshayAnand101, some suggestions
- To properly center the card, add this on your body
min-height: 100vh;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
- Avoid using fixed heights and widths on elements, as this can lead to responsiveness issues and poor content fitting. Instead, let the content and padding dictate the element's size. When necessary, use
max-width
ormin-height
. Update the .containerwidth
to usemax-width
. - Also, change the .img1
width
tomax-width: 100%;
and give it adisplay: block;
Using a modern CSS reset at the start of the styles in every project like this one Modern CSS Reset will help reset a list of default browser styles. - It's best practice linking Google fonts directly in the HTML
head
section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times. - All content should be wrapped within landmarks. Wrap a
footer
tag around the .attribution. - Font-size should be written in
rem
not px. This article explains it better Why font-size must NEVER be in pixels.
Marked as helpful
2