Design comparison
Solution retrospective
I struggled with making it identical to the given design, hence all those paddings and margins in css. Any advice is appreciated! Thank you.
Community feedback
- @danielmrz-devPosted 8 months ago
Hello @Nyynca!
Your solution looks excellent!
I have just one suggestion:
- Use only
<main>
to wrap the main content instead of<main>
,<article>
and<section>
.
š The tags
<article>
and<section>
would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.Unless you have a specific reason to use all three tags, there's no need, considering that you can achieve the same result with only one. It also makes it easier positioning the elements inside.
This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful1 - Use only
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord