Design comparison
Solution retrospective
Hello everyone!!
thankfully i didn't face any problem.
any suggestions are welcomed .
What specific areas of your project would you like help with?Hello everyone!!
thankfully i didn't face any problem.
any suggestions are welcomed .
Community feedback
- @danielmrz-devPosted 5 months ago
Hello there!
Congrats on completing the challenge! ā
Your solution is really impressive!
I've got a couple of ideas (about how to use HTML better) that could make it even stronger:
š First: Think about using
<main>
to wrap your main content instead of<div>
.Imagine
<div>
and<span>
in HTML as basic containers. They're good for holding stuff, but they don't tell us much about what's inside or its purpose on the webpage.š Second: Don't skip heading levels ā start with
<h1>
, then use<h2>
, and so on.It's more than just text size ā it's about structuring your content effectively:
- The
<h1>
to<h6>
tags are used to define HTML headings. <h1>
is for the most important heading.<h6>
is for the least important heading.- Stick to just one
<h1>
per page ā it should be the main title for the whole page.
These tweaks might not change how your page looks, but they'll make your HTML code clearer and help with SEO and accessibility.
Hope that's helpful!
Keep up the great work!
Marked as helpful1 - The
- @DylandeBruijnPosted 5 months ago
@mohammedreddah
Hiya! š
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution š
- Clear descriptive CSS classes
Things you could improve āļø
-
Add a bit of padding to your body element so the card has room to breath on smaller viewports.
-
Try changing the
height: 100vh
on yourbody
tomin-height: 100vh
so thebody
is100vh
at a minimum but still being able to grow in height when the content grows. -
Try using CSS variables to make your values more reusable across your code.
-
Try experimenting more with Flexbox.
-
Try using relative CSS units like
rem
andem
. -
Try putting an
a
tag in your title with ahref
attribute so you get the default click functionality. -
Try making your solution responsive.
I hope you find my feedback valuable, and I would appreciate it greatly if you could mark my comment as helpful if it was! š
Let me know if you have more questions and I'll do my best to answer them. šāāļø
Happy coding! š
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord