Blog Preview Card (Feedback is Appreciated)

Community feedback

• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 11 months ago

  Hey your solution is amazing! 🤩

  📌 Some accessibility and semantics recommendations for your HTML

  • The text "Greg Hooper" should be inside a p or a header, then you can span it only if you need to give custom styles to a part of your p text
  • The path to your favicon is wrong, it should be: href="./src/assets/images/favicon-32x32.png"
  • Maybe the text "HTML & CSS foundations" should go in an h1, then you can apply the a to it

  Marked as helpful

  0

  ---

  

  Nipaaaa1•350

  @Nipaaaa1Posted 11 months ago

  @Blackpachamame Ah I forgot to change the path to favicon. Thanks!

  1
• 

  Robert•190

  @rweiss2010Posted 11 months ago

  Hello there. Your design looks great. I wish I could provide you with feedback but I am only about a month into learning HTML and CSS so you are way ahead of me. I do have a question or two regarding your CSS code. I have read several articles regarding resetting your margins and everything but none of them have specifics on line spacing, and I see that you specify yours as 1.5. You have over 550 lines of code to reset and explain the reset before you start to style. It is beautifully done and I am able to understand it so easily. Thank you for sharing all that.

  First, most articles I found say that newbies should not reset and learn what the standard settings are. Do you agree with that? And second, where did you find guides or articles to help teach you this?

  I am sorry that this is not helpful, and again, your code is super clean and allows me to clearly understand what you did. I will be striving to get to that level.

  0

  ---

  

  Marcos Travaglini•4,840

  @BlackpachamamePosted 11 months ago

  @rweiss2010 The thing is that most of these resets are part of Tailwind CSS, a CSS framework that is being used for this challenge. In other words, just by applying the framework, it already comes with a certain number of rules by default, such as resetting various styles.

  1

  

  Robert•190

  @rweiss2010Posted 11 months ago

  @Blackpachamame Thank you for letting me know. I have not gone over frameworks yet. I want to be efficient and understand the code before I start using frameworks. Thank you for informing me. I am looking forward to learning more!!!

  1