Design comparison
Solution retrospective
Note to self:
- svg and webp files do not work with the <img> tag, use <embed> instead
- learned about box-shadow property
Community feedback
- @danielmrz-devPosted 9 months ago
Hello @Eugeneycchoy!
Your project looks great!
I have one suggestion for you to improve it even more:
- Using
margin
is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:
π Apply this to the body (in order to work properly, don't use position or margins):
body { min-height: 100vh; display: flex; /* it works with grid too */ justify-content: center; align-items: center; }
I hope it helps!
Other than that, great job!
Marked as helpful1@EugeneycchoyPosted 9 months agoHello! @danielmrz-dev
Got it! will keep that in mind. Centering stuff with vanilla CSS wasn't as easy as I thought, I forgot that the body element could be a flex container itself, thanks for the tips and reminder!!!
Cheers!
1 - Using
- @Ezekiel225Posted 9 months ago
Hello there π @Eugeneycchoy.
Good job on completing the challenge !
Your project looks really good!
I have a suggestion about your code that might interest you.
πFirst: Consider adding a min-height of 100vh to the body element so as to centralize your project.
body { min-height: 100vh; align-items: center; display: flex; justify-content: center; }
There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.
I hope this suggestion is useful for future projects.
Keep up the excellent work and continue to challenge yourself with new projects. Your progress is impressive, and each project is a step forward in your front-end development journey! ππ.
Other than that, great job!
Happy coding.
Marked as helpful1@EugeneycchoyPosted 9 months agoHey! @Ezekiel225 Thank you for commenting on my attempt, I'll keep that in mind.
And by the way, omg nice tool, definitely will come in handy very often!!
Thank you for the tips!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord