blog-preview-card done using css

Community feedback

• 

  P

  Steven Stroud•11,910

  @StroudyPosted 2 months ago

  Hey, Great job with this solution you should be proud, A few things I noticed,

  • Missing a <meta> description tag for SEO purposes,
  • Setting a height and width attribute to your <img> will increase performance to reduce layout shifts and improve CLS, It reserves the space on the page for the image,
  • It is best practice to have a <main> tag inside your body highlighting the main section.
  • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
  • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
  • Another great resource for px to rem converter.
  • Having better alt="" descriptions for accessibility is a must check this out Write helpful Alt Text to describe images,
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
  • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.
  • @media should also be in relative units like rem or em,

  I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

  Marked as helpful

  0
• 

  Antonio Riccelli•80

  @Antonio-RiccelliPosted 2 months ago

  Hey Sudhanshu, good work 💪

  Some things you could consider:

  • Although<span> elements can be used to mark microdata or other metadata, you could also consider using block-level tags like <p> or <div> or even heading tags. This could make them more semantically relevant. Just an idea.
  • You could consider splitting the CSS to its separate stylesheet file, but I understand that in such a small challenge it won't make a huge difference.

  Hope this helps! Good work and best of luck with the next challenge.

  Marked as helpful

  0