Blog Preview Card

Community feedback

• 

  P

  Steven Stroud•11,870

  @StroudyPosted 3 months ago

  Hey, Great job with this solution you should be proud, A few things I noticed,

  • Missing a <meta> description tag for SEO purposes,
  • Missing these two meta tags are important for ensuring that a webpage displays correctly across different devices and browsers, Together, these tags ensure proper text display and responsive design, enhancing usability and accessibility across various devices.

  <meta charset="UTF-8" />
  <meta name="viewport" content="width=device-width, initial-scale=1.0" />
  

  • ‍Using max-width: 100% or min-width: 100% is way more responsive then just width:100%, check out this article also from the same Frontend mentor dev responsive-meaning, she goes into more detail.
  • You should avoid using px as it is an absolute unit and not a responsive unit like rem or em, You should look at this article from a Frontend mentor dev, Why font-size must NEVER be in pixels.
  • Another great resource for px to rem converter.
  • You should avoid using position: absolute; because it brings the elements out of the flow, This can cause some unexpected issues with screen sizes.
  • It is best practice to use margin-inline: auto; to center left and right then than just margin: auto;, You can center the height by using this code snippet

    min-height: 100svh;
    display: flex;
    justify-content: center;
    flex-direction: column;
  

  • Line height is usually unitless instead of line-height: 150%; should use line-height: 1.5; this means it is 1.5 x the font-size, unitless value ensures that the line height will scale proportionately.
  • Having better alt="" descriptions for accessibility is a must check this out Write helpful Alt Text to describe images,
  • You should apply a full modern reset to make things easier as you build, check out this site for a Full modern reset
  • Using a naming convention like BEM, Using proper naming will prepare you for the changes in design of the website.

  I hope you found some of this information helpful, You should give the articles a good read and I look forward to seeing some more from you, Happy coding! 💻

  Marked as helpful

  0