Blog preview card. Coded with SASS, BEM, Grid, Flexbox, Semantic HTML.

Community feedback

• 

  CatalinaF-S•60

  @CatalinaF-SPosted 5 months ago

  Hi! Here my feedback to your project :)

  • Does the solution include semantic HTML? Yes, I see that you have used semantic elements to organize your HTML code.

  • Is it accessible, and what improvements could be made? In general you solved the challenge in a very structured way and I don't see anything you should improve or change.

  • Does the layout look good on a range of screen sizes? The layout look good but I am not sure that you have implemented a responsive solution.

  • Is the code well-structured, readable, and reusable? I find really cool how you modularized in components your scss code.

  • Does the solution differ considerably from the design? Your solution is very close to the design proposed in the challenge.

  0

  ---

  

  Jiří Ćmiel•40

  @jiricmielPosted 5 months ago

  Hello @CatalinaF-S, thank you very much for your feedback. I feel honored that you invested a bit of your time in me. You're kinda right about not implementing responsive solution. My workflow is desktop first and from that point of view everything works just fine up until 384px. But I see your point and I made one querry for that resolution so that borders of my card are not touching the sides. I'm gonna repay you the kindness and give you some feedback :-)

  0
• 

  Juan Gomez•260

  @newbpydevPosted 6 months ago

  Hi fellow developer, You seem to have encountered the same problem that I have come across which is the naming of the classes especially using BEM, on most of my projects I try to follow these guidelines:

  • Use more descriptive element names: Ensure each element's name clearly describes its purpose.
  • Avoid unnecessary abbreviations: Use full words for better clarity.
  • Ensure consistency in naming: Maintain a consistent naming pattern throughout the code.

  I have these tips written down on my corkboard so I don't forget to use them on my projects, they might come in handy. Good luck on your journey.

  0

  ---

  

  Jiří Ćmiel•40

  @jiricmielPosted 6 months ago

  @newbpydev thank you very much for your comment. I see BEM as pretty useful but I often get lost while using it. I'll try to stick to your advice. Thx once again.

  0