@CatalinaF-S
Posted
Hi! Here my feedback to your project :)
-
Does the solution include semantic HTML? Yes, I see that you have used semantic elements to organize your HTML code.
-
Is it accessible, and what improvements could be made? In general you solved the challenge in a very structured way and I don't see anything you should improve or change.
-
Does the layout look good on a range of screen sizes? The layout look good but I am not sure that you have implemented a responsive solution.
-
Is the code well-structured, readable, and reusable? I find really cool how you modularized in components your scss code.
-
Does the solution differ considerably from the design? Your solution is very close to the design proposed in the challenge.
@jiricmiel
Posted
Hello @CatalinaF-S, thank you very much for your feedback. I feel honored that you invested a bit of your time in me. You're kinda right about not implementing responsive solution. My workflow is desktop first and from that point of view everything works just fine up until 384px. But I see your point and I made one querry for that resolution so that borders of my card are not touching the sides. I'm gonna repay you the kindness and give you some feedback :-)