Design comparison
Solution retrospective
Please find free to check and suggest any ideas if you have.
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @Bidhu1024!
Your solution looks very good!
I have a few suggestions for improvement:
-
Adding a fixed
width
value for the card can cause some bugs, like the content leaking or being cut off sometimes. It's nice to addmax-width
instead. This will make your project more responsive, but will grow and adapt until the value you specify onmax-width
. -
You can also add a
border-radius
to the image so it'll match the container's border. -
Lastly, you can check the
style-guide
file to see what is the recommendedfont-family
for the project. If my memory is correct, the font for this project is Figtree.
I hope it helps!
Other than those details, you did an excelent job!
Marked as helpful0@Bidhu1024Posted 11 months ago@danielmrz-dev Thanks for your beautiful feedback, I'll work on those.
0 -
- @KruzadeR-VictoRPosted 11 months ago
Hi @Bidhu1024 👋,
i saw your solution and you've done a good job.
Here are some issues i noticed you might consider :
- it's a good practice to wrap all ur contents in a main tag to avoid further accessibility issues, you can learn more about web accessibility here
- consider adding some padding around the card content as in the design
- also add the hover effect in active state of the card ( the "box-shadow" transition )
addition tip :
- while developing, you should always compare your solution with the given designs before submission to achieve best accuracy
Good luck with ur future developments ✌
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord